Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Cancel restart/Kill restart feature #2348

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Implement Cancel restart/Kill restart feature #2348

wants to merge 8 commits into from

Conversation

slinkydeveloper
Copy link
Contributor

Fix #895. Depends on #2335

The fundamental commit where semantics are implements is this one: 0edc593

Essentially the behavior is the following:

  • Cancel and Kill behaviors are left untouched
  • If the "restart" option is enabled when cancelling/killing, at the end of the invocation the state machine will simply reset the in flight invocation status, removing the pinned deployment id and resetting the journal (except the first entry, that is the input entry)

This commit exposes the feature both in Admin API and in CLI

@slinkydeveloper slinkydeveloper force-pushed the issues/895-second-attempt branch from 53e2e64 to fef23e4 Compare December 6, 2024 09:17
@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Dec 9, 2024 •
edited
Loading

We talked offline about:

  • Make sure if you cancel and retry, and then subsequently kill, then kill takes precedence and no retry takes place (to do in this PR) DONE
  • Introduce something like "k8s resource event log" for invocation status with start/finished/retried events (in a followup) WILL DO IN IMMUTABLE JOURNAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman Awaiting requested review from igalshilman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel/Kill and retry invocation from Admin API
1 participant
@slinkydeveloper